Add license files in published crate part of this workspace #318
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a symbolic link to license files in each crate we publish
to avoid problems like this:
$ rust2rpm -t fedora -a -s virtio-vsock 0.6.0
ERROR: No license files were detected. In almost all cases, this is an issue
with the upstream project that should be reported.
In the other unpublished crates we have different licenses that we
should resolve before publishing and link the right license files.
Fixes: rust-vmm#298
Signed-off-by: Stefano Garzarella <[email protected]>
stefano-garzarella
requested review from
alexandruag,
andreeaflorescu,
jiangliu,
slp,
stsquad and
epilys
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the PR
Add a symbolic link to license files in each crate we publish to avoid problems like this:
In the other unpublished crates we have different licenses that we should resolve before publishing and link the right license files.
Fixes: #298
Requirements
Before submitting your PR, please make sure you addressed the following
requirements:
git commit -s), and the commit message has max 60 characters for thesummary and max 75 characters for each description line.
test.
Release" section of CHANGELOG.md (if no such section exists, please create one).
unsafecode is properly documented.